lkml.org 
[lkml]   [2022]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/5] perf: Add SNOOP_PEER flag to perf mem data struct
On Sat, Apr 23, 2022 at 05:53:28AM -0700, Andi Kleen wrote:
>
> > Except SNOOPX_FWD means a no modified cache snooping, it also means it's
> > a cache conherency from *remote* socket. This is quite different from we
> > define SNOOPX_PEER, which only snoop from peer CPU or clusters.
> >
> > If no objection, I prefer we could keep the new snoop type SNOOPX_PEER,
> > this would be easier for us to distinguish the semantics and support the
> > statistics for SNOOPX_FWD and SNOOPX_PEER separately.
> >
> > I overlooked the flag SNOOPX_FWD, thanks a lot for Kan's reminding.
>
> Yes seems better to keep using a separate flag if they don't exactly match.
>
> It's not that we're short on flags anyways.

Thanks for confirmation.

Leo

\
 
 \ /
  Last update: 2022-04-24 13:43    [W:0.121 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site