Messages in this thread | | | Date | Sun, 24 Apr 2022 19:43:02 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v5 2/5] perf: Add SNOOP_PEER flag to perf mem data struct |
| |
On Sat, Apr 23, 2022 at 05:53:28AM -0700, Andi Kleen wrote: > > > Except SNOOPX_FWD means a no modified cache snooping, it also means it's > > a cache conherency from *remote* socket. This is quite different from we > > define SNOOPX_PEER, which only snoop from peer CPU or clusters. > > > > If no objection, I prefer we could keep the new snoop type SNOOPX_PEER, > > this would be easier for us to distinguish the semantics and support the > > statistics for SNOOPX_FWD and SNOOPX_PEER separately. > > > > I overlooked the flag SNOOPX_FWD, thanks a lot for Kan's reminding. > > Yes seems better to keep using a separate flag if they don't exactly match. > > It's not that we're short on flags anyways.
Thanks for confirmation.
Leo
| |