lkml.org 
[lkml]   [2022]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 09/12] clk: imx: scu: Fix kfree() of static memory on setting driver_override
    On 22-04-19 13:34:32, Krzysztof Kozlowski wrote:
    > The driver_override field from platform driver should not be initialized
    > from static memory (string literal) because the core later kfree() it,
    > for example when driver_override is set via sysfs.
    >
    > Use dedicated helper to set driver_override properly.
    >
    > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support")
    > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    > Acked-by: Stephen Boyd <sboyd@kernel.org>

    Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

    > ---
    > drivers/clk/imx/clk-scu.c | 7 ++++++-
    > 1 file changed, 6 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
    > index ed3c01d2e8ae..4996f1d94657 100644
    > --- a/drivers/clk/imx/clk-scu.c
    > +++ b/drivers/clk/imx/clk-scu.c
    > @@ -683,7 +683,12 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name,
    > return ERR_PTR(ret);
    > }
    >
    > - pdev->driver_override = "imx-scu-clk";
    > + ret = driver_set_override(&pdev->dev, &pdev->driver_override,
    > + "imx-scu-clk", strlen("imx-scu-clk"));
    > + if (ret) {
    > + platform_device_put(pdev);
    > + return ERR_PTR(ret);
    > + }
    >
    > ret = imx_clk_scu_attach_pd(&pdev->dev, rsrc_id);
    > if (ret)
    > --
    > 2.32.0
    >

    \
     
     \ /
      Last update: 2022-04-23 18:10    [W:5.205 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site