lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] hv_sock: Copy packets sent by Hyper-V out of the ring buffer
> > @@ -378,6 +381,8 @@ static void hvs_open_connection(struct vmbus_channel *chan)
> > rcvbuf = ALIGN(rcvbuf, HV_HYP_PAGE_SIZE);
> > }
> >
> > + chan->max_pkt_size = HVS_MAX_PKT_SIZE;
> > +
>
> premise, I don't know HyperV channels :-(
>
> Is this change necessary to use hv_pkt_iter_first() instead of
> hv_pkt_iter_first_raw()?

Yes, the change is required to initialize the buffer which holds the
copies of the incoming packets (in hv_ringbuffer_init()).


> If yes, then please mention that you set this value in the commit message,
> otherwise maybe better to have a separate patch.

Sure, will do.

Thanks,
Andrea

\
 
 \ /
  Last update: 2022-04-21 17:22    [W:0.103 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site