lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC][PATCH] ptrace: Don't change __state
Oleg Nesterov <oleg@redhat.com> writes:

> On 04/20, Eric W. Biederman wrote:
>> @@ -892,7 +891,6 @@ static int ptrace_resume(struct task_struct *child, long request,
>> * status and clears the code too; this can't race with the tracee, it
>> * takes siglock after resume.
>> */
>> - need_siglock = data && !thread_group_empty(current);
>> if (need_siglock)
>> spin_lock_irq(&child->sighand->siglock);
>
> Hmm?

A half backed out change (I thought ptrace_resume would need to clear
JOBCTL_DELAY_WAKEKILL) in ptrace_resume. I somehow failed to
restore the need_siglock line.

Eric

\
 
 \ /
  Last update: 2022-04-21 17:01    [W:0.186 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site