lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [External] Re: [PATCH] sched/core: Avoid obvious double update_rq_clock warning
From


On 2022/4/21 Dietmar Eggemann wrote:
> On 18/04/2022 11:09, Hao Jia wrote:
>
> [...]
>
>> - /*
>> - * Update the later_rq clock here, because the clock is used
>> - * by the cpufreq_update_util() inside __add_running_bw().
>> - */
>> - update_rq_clock(later_rq);
>> - activate_task(later_rq, next_task, ENQUEUE_NOCLOCK);
>> + activate_task(later_rq, next_task, 0);
>
> IMHO, this change should go in a separate deadline patch.
>

Thanks again for your review.
I will do it in patch v2.
Thanks.

> The change to call update_rq_clock() before activate_task()
> (840d719604b09) is no longer needed since f4904815f97a removed the
> add_running_bw() before the activate_task().
>
> [...]

\
 
 \ /
  Last update: 2022-04-21 15:17    [W:0.164 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site