Messages in this thread | | | From | Rob Herring <> | Date | Thu, 21 Apr 2022 07:34:37 -0500 | Subject | Re: [PATCH] of: Add missing of_node_put() before return |
| |
+Thomas
On Thu, Apr 21, 2022 at 7:23 AM Wan Jiabing <wanjiabing@vivo.com> wrote: > > Fix the following coccicheck error: > drivers/of/platform.c:554:2-23: WARNING: Function "for_each_node_by_type" > should have of_node_put() before return around line 560.
Especially since the code this fixes just landed, you should Cc the author and reference the commit.
> Early exits from for_each_node_by_type() should decrement the node > reference counter. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > --- > drivers/of/platform.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)
This has to go via the DRM tree.
Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Acked-by: Rob Herring <robh@kernel.org>
| |