lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: wacom: Correct power_supply type
On Wed, 20 Apr 2022, Bastien Nocera wrote:

> > > POWER_SUPPLY_TYPE_USB seems to only ever be used by USB ports that
> > > are
> > > used to charge the machine itself (so a "system" scope), like the
> > > single USB port on a phone, rather than devices.
> > >
> > > The wacom_sys driver is the only driver that sets its device
> > > battery as
> > > being a USB type, which doesn't seem correct based on its usage, so
> > > switch it to be a battery type like all the other USB-connected
> > > devices.
> > >
> > > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > > ---
> > >  drivers/hid/wacom_sys.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> > > index 066c567dbaa2..620fe74f5676 100644
> > > --- a/drivers/hid/wacom_sys.c
> > > +++ b/drivers/hid/wacom_sys.c
> > > @@ -1777,7 +1777,7 @@ static int __wacom_initialize_battery(struct
> > > wacom *wacom,
> > >         bat_desc->get_property = wacom_battery_get_property;
> > >         sprintf(battery->bat_name, "wacom_battery_%ld", n);
> > >         bat_desc->name = battery->bat_name;
> > > -       bat_desc->type = POWER_SUPPLY_TYPE_USB;
> > > +       bat_desc->type = POWER_SUPPLY_TYPE_BATTERY;
> > >         bat_desc->use_for_apm = 0;
> > >  
> > >         ps_bat = devm_power_supply_register(dev, bat_desc,
> > > &psy_cfg);
> >
> > Thanks Bastien, makes sense. CCing Jason and Ping (the Wacom driver
> > maintainers) to get their Ack.
>
> Hey,
>
> I know both Jason and Ping, but their name didn't show up when running
> get_maintainers.pl and neither of their names are in the MAINTAINERS
> file.
>
> This probably needs fixing.

Agreed. Wacom driver is by itself substantial enough in order to have
MAINTAINERS entry.

Jason, Ping, could you please send me a patch adding yourself as
maintainers?

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2022-04-21 10:03    [W:0.070 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site