lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] spi: spi-mem: check if data buffers are on stack
On 20/04/22 02:04PM, Mark Brown wrote:
> On Wed, Apr 20, 2022 at 03:50:22PM +0530, Pratyush Yadav wrote:
> > The buffers passed in the data phase must be DMA-able. Programmers often
> > don't realise this requirement and pass in buffers that reside on the
> > stack. This can be hard to spot when reviewing code. Reject ops if their
> > data buffer is on the stack to avoid this.
> >
> > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> > Acked-by: Mark Brown <broonie@kernel.org>
> > ---
> >
> > Changes in v2:
> > - Include task_stack.h. It might not get included indirectly on some
> > platforms and can cause build failures.
> > - Add a WARN_ON_ONCE() for debuggability.
> > - Add Mark's Ack.
>
> Since this is now an isolated patch does that mean whatever meant that I
> acked rather than applying this patch has gone in and I can now apply it
> directly?

Yes, you should be able to apply it directly. Miquel's spi-mem-ecc
branch is now in 5.18-rc1 and later. Though this patch never conflicted
with that branch to begin with. The spi-mem-ecc branch does not touch
spi_mem_check_op() as far as I can see.

--
Regards,
Pratyush Yadav
Texas Instruments Inc.

\
 
 \ /
  Last update: 2022-04-21 09:13    [W:0.079 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site