Messages in this thread | | | Date | Wed, 20 Apr 2022 18:46:43 +0100 | Subject | Re: [PATCH v3 1/3] soundwire: qcom: add runtime pm support | From | Srinivas Kandagatla <> |
| |
On 20/04/2022 18:39, Pierre-Louis Bossart wrote: >> @@ -1197,12 +1224,23 @@ static int qcom_swrm_get_port_config(struct qcom_swrm_ctrl *ctrl) >> static int swrm_reg_show(struct seq_file *s_file, void *data) >> { >> struct qcom_swrm_ctrl *swrm = s_file->private; >> - int reg, reg_val; >> + int reg, reg_val, ret; >> + >> + ret = pm_runtime_get_sync(swrm->dev); >> + if (ret < 0 && ret != -EACCES) { >> + dev_err_ratelimited(swrm->dev, >> + "pm_runtime_get_sync failed in %s, ret %d\n", >> + __func__, ret); >> + pm_runtime_put_noidle(swrm->dev); > ... here it's missing? > > I have a fix ready but thought I would check first if this was intentional
Its not intentional.
> > https://github.com/thesofproject/linux/pull/3602/commits/6353eec8dc971c5f0fda0166ae1777f71784ea32
Fix looks good.
--srini >
| |