Messages in this thread | | | Date | Wed, 20 Apr 2022 08:47:21 +0200 | Subject | Re: [PATCH 1/3] dt-bindings: arm: mediatek: topckgen: Convert to DT schema | From | Krzysztof Kozlowski <> |
| |
On 19/04/2022 20:09, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Convert topckgen bindings to DT schema format. MT2701, MT7623 and > MT7629 device trees currently have the syscon compatible without > it being mentioned in the old DT bindings file which introduces > dtbs_check errors when converting to DT schema as-is, so > mediatek,mt2701-topckgen and mediatek,mt7629-topckgen are placed > in the last items list with the syscon compatible, and syscon is > added to the mediatek,mt7623-topckgen list. >
Thank you for your patch. There is something to discuss/improve.
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml > new file mode 100644 > index 000000000000..9ce9cf673cbc > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,topckgen.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: MediaTek Top Clock Generator Controller > + > +maintainers: > + - Matthias Brugger <matthias.bgg@gmail.com> > + > +description: > + The Mediatek topckgen controller provides various clocks to the system. > + > +properties: > + compatible: > + oneOf: > + - items:
These are not a list, so skip items. Just enum. Rest looks good.
> + - enum: > + - mediatek,mt6797-topckgen > + - mediatek,mt7622-topckgen > + - mediatek,mt8135-topckgen > + - mediatek,mt8173-topckgen > + - mediatek,mt8516-topckgen
Best regards, Krzysztof
| |