lkml.org 
[lkml]   [2022]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v1 3/3] dt-bindings: iio: accel: add dt-binding schema for msa311 accel driver
    On Tue, 19 Apr 2022 15:45:58 +0000
    Rokosov Dmitry Dmitrievich <DDRokosov@sberdevices.ru> wrote:

    > Introduce devicetree binding json-schema for MSA311 tri-axial,
    > low-g accelerometer driver.
    >
    > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
    Hi Dmitry and welcome to IIO.

    Sign off generally matches the From: of the email.
    Makes it easier for scripts to check than having different name forms.

    > ---
    > .../bindings/iio/accel/memsensing,msa311.yaml | 64 ++++++++++++++++++++++
    > MAINTAINERS | 1 +
    > 2 files changed, 65 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
    > new file mode 100644
    > index 00000000..3e4660f
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
    > @@ -0,0 +1,64 @@
    > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
    > +
    > +%YAML 1.2
    > +---
    > +$id: "http://devicetree.org/schemas/iio/accel/memsensing,msa311.yaml#"
    > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
    > +
    > +title: MEMSensing digital 3-Axis accelerometer
    > +
    > +maintainers:
    > + - Dmitry Rokosov <ddrokosov@sberdevices.ru>
    > +
    > +description: |
    > + MSA311 is a tri-axial, low-g accelerometer with I2C digital output for
    > + sensitivity consumer applications. It has dynamical user selectable full
    > + scales range of +-2g/+-4g/+-8g/+-16g and allows acceleration measurements
    > + with output data rates from 1Hz to 1000Hz.
    > + Datasheet can be found at following URL
    > + https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.pdf
    > +
    > +properties:
    > + compatible:
    > + const: memsensing,msa311
    > +
    > + "#address-cells":
    > + const: 1
    > +
    > + "#size-cells":
    > + const: 0
    > +
    > + reg:
    > + maxItems: 1
    > + description: I2C registers address
    > +
    > + interrupts:
    > + maxItems: 1
    > + description: optional I2C int pin can be freely mapped to specific func
    > +
    > + interrupt-names:
    > + const: irq
    For a single IRQ giving it a name isn't that useful so I would drop this.


    > +
    > +required:
    > + - compatible
    > + - reg
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + - |
    > + #include <dt-bindings/gpio/gpio.h>

    Why have this?

    > + #include <dt-bindings/interrupt-controller/irq.h>
    > + i2c0 {
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > +
    > + msa311: msa311@62 {
    Generic naming required.
    accelerometer@62 {
    > + compatible = "memsensing,msa311";
    > + reg = <0x62>;
    > + interrupt-parent = <&gpio_intc>;
    > + interrupts = <29 IRQ_TYPE_LEVEL_HIGH>;
    > + interrupt-names = "irq";
    > + status = "okay";

    We don't often have status in the examples.


    Otherwise looks good to me.

    Thanks,

    Jonathan

    > + };
    > + };
    > diff --git a/MAINTAINERS b/MAINTAINERS
    > index c75be17..4227914 100644
    > --- a/MAINTAINERS
    > +++ b/MAINTAINERS
    > @@ -12482,6 +12482,7 @@ MEMSENSING MICROSYSTEMS MSA311 ACCELEROMETER DRIVER
    > M: Dmitry Rokosov <ddrokosov@sberdevices.ru>
    > L: linux-iio@vger.kernel.org
    > S: Maintained
    > +F: Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
    > F: drivers/iio/accel/msa311.c
    >
    > MEN A21 WATCHDOG DRIVER

    \
     
     \ /
      Last update: 2022-04-20 10:54    [W:4.167 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site