lkml.org 
[lkml]   [2022]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ntb_perf: fix doubletest cocci warning
Thanks, nice catch.
I'll include it into the next patch version.

Regards,
Alexander.

вт, 19 апр. 2022 г. в 18:50, Logan Gunthorpe <logang@deltatee.com>:
>
>
>
> On 2022-04-19 01:18, Guo Zhengkui wrote:
> > `!data->ops.init` has been repeated triple. The original logic is to
> > check whether `.init`, `.run` and `.clear` callbacks are NULL or not.
> >
> > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
>
> This appears to be a patch against Alexander's patch which has not been
> accepted yet. Posting a note on his patch so he fixes it for the next
> posting would be preferable.
>
> Logan
>
> > ---
> > drivers/ntb/test/ntb_perf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> > index c106c3a5097e..dcae4be91365 100644
> > --- a/drivers/ntb/test/ntb_perf.c
> > +++ b/drivers/ntb/test/ntb_perf.c
> > @@ -1451,7 +1451,7 @@ static void perf_ext_lat_work(struct work_struct *work)
> > {
> > struct perf_ext_lat_data *data = to_ext_lat_data(work);
> >
> > - if (!data->ops.init || !data->ops.init || !data->ops.init) {
> > + if (!data->ops.init || !data->ops.run || !data->ops.clear) {
> > struct perf_ctx *perf = data->perf;
> >
> > data->status = -EFAULT;

\
 
 \ /
  Last update: 2022-04-20 10:47    [W:0.043 / U:3.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site