lkml.org 
[lkml]   [2022]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mm/mmu_notifier.c: Fix race in mmu_interval_notifier_remove()
On Thu, 21 Apr 2022 09:21:06 +1000 Alistair Popple <apopple@nvidia.com> wrote:

> >> As the wait_event() condition is true it will return immediately. This
> >> can lead to use-after-free type errors if the caller frees the data
> >> structure containing the interval notifier subscription while it is
> >> still on a deferred list. Fix this by taking the appropriate lock when
> >> reading invalidate_seq to ensure proper synchronisation.
> >>
> >> ...
> >>
> >> Fixes: 99cb252f5e68 ("mm/mmu_notifier: add an interval tree notifier")
> >
> > Do you think fix this should be backported into older kernels?
>
> Yes, I forgot to cc stable sorry.

So we have actually seen these use-after-free errors?

Some description of the end-user visible impact is always helpful when
deciding which trees need a patch.

> Do you want me to resend with
> 'Cc: stable@vger.kernel.org'?

Thanks, I added that.

\
 
 \ /
  Last update: 2022-04-21 01:35    [W:0.091 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site