lkml.org 
[lkml]   [2022]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: r8188eu: Remove goto to no-op exit label
Thus wrote Fabio M. De Francesco (fmdefrancesco@gmail.com):

> > > pnpi = netdev_priv(netdev);

> > > if (!pnpi->priv)
> > > - goto RETURN;
> > > + return;

> I cannot see how pnpi->priv might ever be NULL.

Even if pnpi->priv was NULL, we wouldn't need the check. It's ok to call
vfree(NULL).

> After the two removals I've talked about above, the code will always call
> vfree(pnpi->priv) and then free_netdev(netdev).

That makes sense.

Best regards,
Martin

\
 
 \ /
  Last update: 2022-04-02 13:50    [W:0.048 / U:1.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site