lkml.org 
[lkml]   [2022]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/amd/display: add virtual_setup_stream_attribute decl to header
Applied.  Thanks!

On Mon, Apr 18, 2022 at 3:48 PM Tom Rix <trix@redhat.com> wrote:
>
> Smatch reports this issue
> virtual_link_hwss.c:32:6: warning: symbol
> 'virtual_setup_stream_attribute' was not declared.
> Should it be static?
>
> virtual_setup_stream_attribute is only used in
> virtual_link_hwss.c, but the other functions in the
> file are declared in the header file and used elsewhere.
> For consistency, add the virtual_setup_stream_attribute
> decl to virtual_link_hwss.h.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> index e6bcb4bb0f3a..fbcbc5afb47d 100644
> --- a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> +++ b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> @@ -28,6 +28,7 @@
> #include "core_types.h"
>
> void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
> +void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
> void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
> const struct link_hwss *get_virtual_link_hwss(void);
>
> --
> 2.27.0
>

\
 
 \ /
  Last update: 2022-04-19 16:52    [W:0.040 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site