lkml.org 
[lkml]   [2022]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver
On 4/19/22 07:19, Sathyanarayanan Kuppuswamy wrote:
> On 4/19/22 7:13 AM, Dave Hansen wrote:
>>> >From this perspective, I am not sure what's the value of having a
>>> dedicated
>>> INTEL_TDX_ATTESTATION Kconfig.  The attestation support code should
>>> be turned on
>>> unconditionally when CONFIG_INTEL_TDX_GUEST is on.  The code can also
>>> be just
>>> under arch/x86/coco/tdx/ I guess?
>> How much code are we talking about?  What's the difference in the size
>> of the binaries with this compiled in?
>
> Current driver size is ~300 lines. It adds ~500 bytes to the kernel
> binary if it is built-in.

That doesn't sound like good use of a Kconfig option to me. Just
explain in the cover letter:

Any distribution enabling TDX is also expected to need
attestation. The compiled size is quite small (500 bytes).

\
 
 \ /
  Last update: 2022-04-19 16:26    [W:0.076 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site