lkml.org 
[lkml]   [2022]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 0/2] Introduce Intra-refresh type control
Date
Hi Stan,

I was waiting for your comments on Venus changes if any, so that I can address all comments together in next patch.
Posted a new patchset v5 now, pls review.

Thanks,
Dikshita Agarwal

-----Original Message-----
From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Sent: Thursday, April 07, 2022 1:53 AM
To: Dikshita Agarwal (QUIC) <quic_dikshita@quicinc.com>; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; hverkuil-cisco@xs4all.nl
Cc: linux-arm-msm@vger.kernel.org; ezequiel@collabora.com; stanimir.varbanov@linaro.org; quic_vgarodia@quicinc.com; Maheshwar Ajja (QUIC) <quic_majja@quicinc.com>; quic_jdas <quic_jdas@quicinc.com>
Subject: Re: [PATCH v4 0/2] Introduce Intra-refresh type control

Dikshita,

I cannot find new version of this patchset with Han's comments addressed?

On 3/14/22 12:09, quic_dikshita@quicinc.com wrote:
> From: Dikshita Agarwal <quic_dikshita@quicinc.com>
>
> Hi,
>
> This series add a new intra-refresh type control for encoders.
> this can be used to specify which intra refresh to be enabled, random, cyclic or none.
>
> Change since v0:
> Dropped INTRA_REFRESH_TYPE_NONE as it was not needed.
> Intra refresh period value as zero will disable the intra refresh.
>
> Change since v1:
> Updated the control name for better undestanding.
> Also updated the documentation accordingly.
>
> Change since v2:
> Updated the venus driver implementation as well to use the correct control name. Missed in v2.
>
> Change since v3:
> Addressed comments from Hans in v4l2 patch.
> Enabled the support for cyclic intra refresh in venus driver.
>
> Thanks,
> Dikshita
>
> Dikshita Agarwal (2):
> media: v4l2-ctrls: Add intra-refresh type control
> venus: venc: Add support for intra-refresh mode
>
> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 22 ++++++++++++++++++++++
> drivers/media/platform/qcom/venus/core.h | 1 +
> drivers/media/platform/qcom/venus/venc.c | 6 +++++-
> drivers/media/platform/qcom/venus/venc_ctrls.c | 10 ++++++++++
> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 9 +++++++++
> include/uapi/linux/v4l2-controls.h | 5 +++++
> 6 files changed, 52 insertions(+), 1 deletion(-)
>

--
regards,
Stan
\
 
 \ /
  Last update: 2022-04-19 07:10    [W:3.228 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site