Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Tue, 19 Apr 2022 09:56:53 +0200 | Subject | Re: [PATCH] extcon: ptn5150: add usb role class support |
| |
On Tue, 19 Apr 2022 at 09:53, Jun Li <jun.li@nxp.com> wrote: > > > > @@ -132,6 +132,7 @@ config EXTCON_PTN5150 > > > > tristate "NXP PTN5150 CC LOGIC USB EXTCON support" > > > > depends on I2C && (GPIOLIB || COMPILE_TEST) > > > > select REGMAP_I2C > > > > + select USB_ROLE_SWITCH > > > > > > You do not need to select it. Driver will work without role switch, > > > won't it? If it works, then probably it should be just imply. > > > > Okay, usb role class provider should enable this for me, will drop it. > > A second check on this and I think I still need this, there > maybe some usb controller driver without usb role switch > + ptn5150 via extcon, so no need USB_ROLE_SWITCH, I need > select it to avoid build break.
What build problem exactly? Aren't there stubs for !USB_ROLE_SWITCH case?
Best regards, Krzysztof
| |