lkml.org 
[lkml]   [2022]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/7] clk: mediatek: reset: Merge and revise reset register function
    On Mon, Apr 18, 2022 at 9:22 PM Rex-BC Chen <rex-bc.chen@mediatek.com> wrote:
    >
    > Merge the reset register function of v1 and v2 into one function.
    > - Input the version number to determine which version we will use.
    > - Add return value of reset register function for error handling.

    Please do this in a separate patch. Also you are adding error messages
    for when of_clk_add_provider() fails, which is not mentioned either.

    Most of these platform drivers require a good cleanup of their error
    handling anyway. It might be a good idea to tackle them later. Or if
    they look the same, you could try using coccinelle to do a bulk cleanup.


    Thanks
    ChenYu

    > - Rename reset register function to "mtk_clk_register_rst_ctrl"

    \
     
     \ /
      Last update: 2022-04-19 09:27    [W:6.125 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site