| Date | Tue, 19 Apr 2022 19:14:45 +0200 | From | Greg KH <> | Subject | Re: [PATCH v3 05/11] platform/x86/intel/ifs: Read IFS firmware image |
| |
On Tue, Apr 19, 2022 at 09:38:53AM -0700, Tony Luck wrote: > +/* > + * Load ifs image. Before loading ifs module, the ifs image must be located > + * in /lib/firmware/intel/ifs and named as {family/model/stepping}.{testname}. > + */ > +int load_ifs_binary(struct device *dev)
Shouldn't all of your global symbols start with "ifs_"? Your other ones seem to, what went wrong here?
Also, how about "ifs_load_firmware()" makes more sense.
thanks,
greg "naming is hard" k-h
|