Messages in this thread | | | Date | Tue, 19 Apr 2022 18:10:47 +0100 | From | Paul Cercueil <> | Subject | Re: [PATCH 1/3] SPI: Ingenic: Add support for use GPIO as chip select line. |
| |
Hi,
Le mar., avril 19 2022 at 18:00:41 +0100, Mark Brown <broonie@kernel.org> a écrit : > On Sat, Apr 16, 2022 at 05:36:46PM +0100, Paul Cercueil wrote: >> Le sam., avril 16 2022 at 19:55:13 +0800, Zhou Yanjie >> > On 2022/4/15 下午11:00, Paul Cercueil wrote: > >> > > > - ctlr->num_chipselect = 2; >> > > > + ctlr->use_gpio_descriptors = true; > >> > > I wonder if this should be set conditionally instead. Maybe set >> it >> > > to "true" if the "num-cs" property exists? > >> > I'm not too sure, but it seems some other drivers like >> "spi-sun6i.c", >> > "spi-stm32.c", "spi-s3c64xx.c", "spi-pic32.c", etc. set it >> > unconditionally. > >> Ok, maybe Mark can enlighten us here. > > use_gpio_descriptions is just selecting which version of the GPIO APIs > we should use if we're handling GPIOs rather than if we should handle > them. We've got one last driver using the numerical GPIO APIs, once > that one is converted we should just be able to drop the flag since > everything will be using descriptors.
Thank you Mark.
Cheers, -Paul
| |