lkml.org 
[lkml]   [2022]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 160/189] ALSA: pcm: Test for "silence" field in struct "pcm_format_data"
    Date
    From: Fabio M. De Francesco <fmdefrancesco@gmail.com>

    commit 2f7a26abb8241a0208c68d22815aa247c5ddacab upstream.

    Syzbot reports "KASAN: null-ptr-deref Write in
    snd_pcm_format_set_silence".[1]

    It is due to missing validation of the "silence" field of struct
    "pcm_format_data" in "pcm_formats" array.

    Add a test for valid "pat" and, if it is not so, return -EINVAL.

    [1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/

    Reported-and-tested-by: syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com
    Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20220409012655.9399-1-fmdefrancesco@gmail.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/core/pcm_misc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/core/pcm_misc.c
    +++ b/sound/core/pcm_misc.c
    @@ -433,7 +433,7 @@ int snd_pcm_format_set_silence(snd_pcm_f
    return 0;
    width = pcm_formats[(INT)format].phys; /* physical width */
    pat = pcm_formats[(INT)format].silence;
    - if (! width)
    + if (!width || !pat)
    return -EINVAL;
    /* signed or 1 byte data */
    if (pcm_formats[(INT)format].signd == 1 || width <= 8) {

    \
     
     \ /
      Last update: 2022-04-18 15:01    [W:2.745 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site