lkml.org 
[lkml]   [2022]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 189/219] ath9k: Properly clear TX status area before reporting to mac80211
    Date
    From: Toke Høiland-Jørgensen <toke@toke.dk>

    commit 037250f0a45cf9ecf5b52d4b9ff8eadeb609c800 upstream.

    The ath9k driver was not properly clearing the status area in the
    ieee80211_tx_info struct before reporting TX status to mac80211. Instead,
    it was manually filling in fields, which meant that fields introduced later
    were left as-is.

    Conveniently, mac80211 actually provides a helper to zero out the status
    area, so use that to make sure we zero everything.

    The last commit touching the driver function writing the status information
    seems to have actually been fixing an issue that was also caused by the
    area being uninitialised; but it only added clearing of a single field
    instead of the whole struct. That is now redundant, though, so revert that
    commit and use it as a convenient Fixes tag.

    Fixes: cc591d77aba1 ("ath9k: Make sure to zero status.tx_time before reporting TX status")
    Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
    Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>
    Signed-off-by: Kalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/20220330164409.16645-1-toke@toke.dk
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/wireless/ath/ath9k/xmit.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    --- a/drivers/net/wireless/ath/ath9k/xmit.c
    +++ b/drivers/net/wireless/ath/ath9k/xmit.c
    @@ -2553,6 +2553,8 @@ static void ath_tx_rc_status(struct ath_
    struct ath_hw *ah = sc->sc_ah;
    u8 i, tx_rateindex;

    + ieee80211_tx_info_clear_status(tx_info);
    +
    if (txok)
    tx_info->status.ack_signal = ts->ts_rssi;

    @@ -2595,9 +2597,6 @@ static void ath_tx_rc_status(struct ath_
    }

    tx_info->status.rates[tx_rateindex].count = ts->ts_longretry + 1;
    -
    - /* we report airtime in ath_tx_count_airtime(), don't report twice */
    - tx_info->status.tx_time = 0;
    }

    static void ath_tx_processq(struct ath_softc *sc, struct ath_txq *txq)

    \
     
     \ /
      Last update: 2022-04-18 14:42    [W:2.432 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site