lkml.org 
[lkml]   [2022]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 02/15] drm/virtio: Check whether transferred 2D BO is shmem
    Date
    Transferred 2D BO always must be a shmem BO. Add check for that to prevent
    NULL dereference if userspace passes a VRAM BO.

    Cc: stable@vger.kernel.org
    Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
    Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
    ---
    drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
    index 7c052efe8836..2edf31806b74 100644
    --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
    +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
    @@ -595,7 +595,7 @@ void virtio_gpu_cmd_transfer_to_host_2d(struct virtio_gpu_device *vgdev,
    bool use_dma_api = !virtio_has_dma_quirk(vgdev->vdev);
    struct virtio_gpu_object_shmem *shmem = to_virtio_gpu_shmem(bo);

    - if (use_dma_api)
    + if (virtio_gpu_is_shmem(bo) && use_dma_api)
    dma_sync_sgtable_for_device(vgdev->vdev->dev.parent,
    shmem->pages, DMA_TO_DEVICE);

    --
    2.35.1
    \
     
     \ /
      Last update: 2022-04-18 00:38    [W:5.104 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site