Messages in this thread | | | Date | Sun, 17 Apr 2022 20:47:13 +0200 | Subject | Re: [PATCH v7 3/6] crypto: caam - add in-kernel interface for blob generator | From | Ahmad Fatoum <> |
| |
Hello Jarkko,
On 17.04.22 17:02, Jarkko Sakkinen wrote: > On Fri, 2022-04-15 at 22:56 +0200, Ahmad Fatoum wrote: >> +int caam_process_blob(struct caam_blob_priv *priv, >> + struct caam_blob_info *info, bool encap) > > Documentation missing (it's exported).
It's documented in the header.
>> +/** struct caam_blob_info - information for CAAM blobbing >> + * > > You can remove this extra line, applies to some functions in the patch > too.
You mean the blank line? Ye, that looks like it doesn't matter. I just ran scripts/kernel-doc and apparently I need a space before the struct caam_blob_info part, so it's even registered as a kernel doc.
Will fix for v8.
> BR, Jarkko
Thanks for the review.
Cheers, Ahmad
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |