lkml.org 
[lkml]   [2022]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: rtl8712: fix uninit-value "data" and "mac"
From
Hi Wang,

On 4/15/22 12:57, Wang Cheng wrote:
> Hi Pavel, thx for your review.
>
> Sorry, this patch is just confined to fixing uninit-values with
> modifying the original code as less as possible. It sounds good to
> refactor r8712_usbctrl_vendorreq() with better API.
>

I understand your idea, but this will just hide the real problem until
syzbot hit it in different place. So, I believe, it's better to fix the
root case instead of hiding local cases.




With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2022-04-16 12:59    [W:0.386 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site