lkml.org 
[lkml]   [2022]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/8] firmware_loader: Add firmware-upload support
On Fri, Apr 15, 2022 at 01:08:01PM -0700, Russ Weight wrote:
> +EXPORT_SYMBOL_GPL(firmware_upload_unregister);
> diff --git a/drivers/base/firmware_loader/sysfs_upload.h b/drivers/base/firmware_loader/sysfs_upload.h
> new file mode 100644
> index 000000000000..a72d0e82e107
> --- /dev/null
> +++ b/drivers/base/firmware_loader/sysfs_upload.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __FIRMWARE_UPLOAD_H
> +#define __FIRMWARE_UPLOAD_H
> +
> +#include <linux/device.h>
> +
> +/* Update progress codes */
> +enum fw_upload_prog {
> + FW_UPLOAD_PROG_IDLE,
> + FW_UPLOAD_PROG_RECEIVING,
> + FW_UPLOAD_PROG_PREPARING,
> + FW_UPLOAD_PROG_TRANSFERRING,
> + FW_UPLOAD_PROG_PROGRAMMING,
> + FW_UPLOAD_PROG_MAX
> +};

This is all looking good to me, thanks for all the work and testing!
Can you just add kdoc entries for the above as well?

Other than that:

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

Luis

\
 
 \ /
  Last update: 2022-04-16 00:56    [W:0.094 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site