lkml.org 
[lkml]   [2022]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net 2/2] ip6_gre: Fix skb_under_panic in __gre6_xmit()
    On Thu, 14 Apr 2022 13:08:54 -0700 Peilin Ye wrote:
    > > We should also reject using SEQ with collect_md, but that's a separate
    > > issue.
    >
    > Could you explain this a bit more? It seems that commit 77a5196a804e
    > ("gre: add sequence number for collect md mode.") added this
    > intentionally.

    Interesting. Maybe a better way of dealing with the problem would be
    rejecting SEQ if it's not set on the device itself.

    When the device is set up without the SEQ bit enabled it disables Tx
    locking (look for LLTX). This means that multiple CPUs can try to do
    the tunnel->o_seqno++ in parallel. Not catastrophic but racy for sure.

    \
     
     \ /
      Last update: 2022-04-15 19:12    [W:6.388 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site