Messages in this thread | | | Date | Fri, 15 Apr 2022 18:45:41 +0200 | From | Clément Léger <> | Subject | Re: [PATCH net-next 09/12] ARM: dts: r9a06g032: describe MII converter |
| |
Le Fri, 15 Apr 2022 18:19:46 +0200, Andrew Lunn <andrew@lunn.ch> a écrit :
> > I think it would be good to modify it like this: > > > > eth-miic@44030000 { > > ... > > converters { > > mii_conv0: mii-conv@0 { > > // Even if useless, maybe keeping it for the sake of coherency > > renesas,miic-input = <MIIC_GMAC1>; > > reg = <0>; > > }; > > This is not a 'bus', so using reg, and @0, etc is i think wrong. You > just have a collection of properties.
Agreed, but this is the same thing that is done for DSA ports (at least I think). It uses reg which describe the port number, this is not a real bus per se, it only refer to port indices.
But if you think this should not be done like this, what do you propose then ? These nodes are also reference from "pcs-handle" properties in switch to retrieve the PCS. Would you suggest using something like pcs-handle = <ð_miic port_index> and remove the nodes then ?
Thanks,
-- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com
| |