Messages in this thread | | | Date | Fri, 15 Apr 2022 10:48:13 -0500 | Subject | Re: [PATCH v3 0/8] staging: r8188eu: fix and clean up some firmware code | From | Larry Finger <> |
| |
On 4/15/22 07:10, Michael Straube wrote: > This series fixes wrong size of struct rt_firmware_hdr in the first > patch and does some cleanups in rtl8188e_firmware_download() in the > other patches. > > Tested on x86_64 with Inter-Tech DMG-02. > > v3: > - Splitted the first patch into two separate patches. > - Added back logging the firmware version only once. > - Included the compile time check for size of rt_firmware from > patch 8/8 of v2 in the patch that replaces the hardcoded size. > > v2: > - Added a patch to check size of struct rt_firmware_hdr at compile time. > > Michael Straube (8): > staging: r8188eu: fix struct rt_firmware_hdr > staging: r8188eu: convert u32 fields of rt_firmware_hdr to __le32 > staging: r8188eu: clean up comments in struct rt_firmware_hdr > staging: r8188eu: rename fields of struct rt_firmware_hdr > staging: r8188eu: use sizeof instead of hardcoded firmware header size > staging: r8188eu: remove variables from rtl8188e_firmware_download() > staging: r8188eu: use pr_info_once() to log the firmware version > staging: r8188eu: check firmware header existence before access > > drivers/staging/r8188eu/core/rtw_fw.c | 79 ++++++++++----------------- > 1 file changed, 29 insertions(+), 50 deletions(-)
Most of this is fine, other than the removal of in-line comments in patch 3/8.
Larry
| |