lkml.org 
[lkml]   [2022]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/2] drm/vkms: check plane_composer->map[0] before using it
    Date
    Fix a copypasta error. The caller of compose_plane() already checks
    primary_composer->map. In contrast, plane_composer->map is never
    verified here before handling.

    Fixes: 7938f4218168 ("dma-buf-map: Rename to iosys-map")
    Reviewed-by: André Almeida <andrealmeid@riseup.net>
    Signed-off-by: Tales Lelo da Aparecida <tales.aparecida@gmail.com>
    ---
    v2: detail the commit message with more information

    drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
    index c6a1036bf2ea..b47ac170108c 100644
    --- a/drivers/gpu/drm/vkms/vkms_composer.c
    +++ b/drivers/gpu/drm/vkms/vkms_composer.c
    @@ -157,7 +157,7 @@ static void compose_plane(struct vkms_composer *primary_composer,
    void *vaddr;
    void (*pixel_blend)(const u8 *p_src, u8 *p_dst);

    - if (WARN_ON(iosys_map_is_null(&primary_composer->map[0])))
    + if (WARN_ON(iosys_map_is_null(&plane_composer->map[0])))
    return;

    vaddr = plane_composer->map[0].vaddr;
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-04-15 16:16    [W:3.819 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site