Messages in this thread | | | Date | Fri, 15 Apr 2022 14:24:01 +0200 | Subject | Re: [PATCH V3 13/15] arm64: dts: mediatek: Add opp table and clock property for MT8183 cpufreq | From | AngeloGioacchino Del Regno <> |
| |
Il 15/04/22 07:59, Rex-BC Chen ha scritto: > - Add cpufreq opp table. > - Add MediaTek cci opp table. > - Add property of opp table and clock fro cpufreq. > > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 32 +++ > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 270 ++++++++++++++++++++ > 2 files changed, 302 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts > index f3fd3cca23e9..8953dbf84f3e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
..snip..
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 4b08691ed39e..4ae3305d16d2 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -42,6 +42,244 @@ > rdma1 = &rdma1; > }; > > + cluster0_opp: cluster_opp_table0 {
Please don't use underscores in devicetree for anything that's not a phandle.
cluster0_opp: cluster0-opp-table {
> + compatible = "operating-points-v2"; > + opp-shared; > + opp0_00 {
Apart from the underscore being invalid, across the kernel, you can find many instances of opp tables, containing names related to the frequencies, so, for consistency (this is not a rule!), perhaps it would be a good idea to do so.
opp-793000000 {
> + opp-hz = /bits/ 64 <793000000>; > + opp-microvolt = <650000>; > + required-opps = <&opp2_00>; > + }; > + opp0_01 {
opp-910000000 {
> + opp-hz = /bits/ 64 <910000000>; > + opp-microvolt = <687500>; > + required-opps = <&opp2_01>; > + }; > + opp0_02 {
..snip..
> + opp0_15 { > + opp-hz = /bits/ 64 <1989000000>; > + opp-microvolt = <1050000>; > + required-opps = <&opp2_15>;
P.S.: Please fix the typo below!
> + }; }; > + > +
...also...
> + cci_opp: opp_table2 {
cci_opp: cci-opp-table {
> + compatible = "operating-points-v2"; > + opp-shared; > + opp2_00: opp-273000000 {
This one is fine instead :))
Cheers, Angelo
| |