Messages in this thread | | | Date | Fri, 15 Apr 2022 14:09:06 +0200 | From | Peter Zijlstra <> | Subject | Re: [patch 2/3] timekeeping: Mark tk_clock_read() __always_inline |
| |
On Fri, Apr 15, 2022 at 11:19:36AM +0200, Thomas Gleixner wrote: > Compilers can uninline this which makes the notrace annotation of the NMI > safe accessors moot.
inline already implies notrace.
No objection to making it __always_inline, but this reason doesn't really work.
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > kernel/time/timekeeping.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/kernel/time/timekeeping.c > +++ b/kernel/time/timekeeping.c > @@ -186,7 +186,7 @@ static inline void tk_update_sleep_time( > * a read of the fast-timekeeper tkrs (which is protected by its own locking > * and update logic). > */ > -static inline u64 tk_clock_read(const struct tk_read_base *tkr) > +static __always_inline u64 tk_clock_read(const struct tk_read_base *tkr) > { > struct clocksource *clock = READ_ONCE(tkr->clock); > >
| |