lkml.org 
[lkml]   [2022]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] RISC-V: mm: Fix set_satp_mode() for platform not having Sv57
On Fri, Apr 15, 2022 at 10:18 AM 潘庆霖 <panqinglin2020@iscas.ac.cn> wrote:
>
> Hi Anup,
>
> &gt;
> &gt; When Sv57 is not available the satp.MODE test in set_satp_mode() will
> &gt; fail and lead to pgdir re-programming for Sv48. The pgdir re-programming
> &gt; will fail as well due to pre-existing pgdir entry used for Sv57 and as
> &gt; a result kernel fails to boot on RISC-V platform not having Sv57.
> &gt;
> &gt; To fix above issue, we should clear the pgdir memory in set_satp_mode()
> &gt; before re-programming.
> &gt;
> &gt; Fixes: 011f09d12052 ("riscv: mm: Set sv57 on defaultly")
> &gt; Reported-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> &gt; Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> &gt; ---
> &gt; arch/riscv/mm/init.c | 1 +
> &gt; 1 file changed, 1 insertion(+)
> &gt;
> &gt; diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> &gt; index 9535bea8688c..b0793dc0c291 100644
> &gt; --- a/arch/riscv/mm/init.c
> &gt; +++ b/arch/riscv/mm/init.c
> &gt; @@ -718,6 +718,7 @@ static __init void set_satp_mode(void)
> &gt; if (!check_l4) {
> &gt; disable_pgtable_l5();
> &gt; check_l4 = true;
> &gt; + memset(early_pg_dir, 0, PAGE_SIZE);
> &gt; goto retry;
> &gt; }
> &gt; disable_pgtable_l4();
> &gt; --
>
>
> I find it that the set_satp_mode function is in .init.text section which begins at 0x80800000.
> And its pgd_index in both Sv48 and Sv57 will be 0. So it may not be necessary to clear the
> early_pg_dir when the kernel find Sv57 is not supported? And may I get the steps of reproduction
> from you?

We can't assume that it will be the same pgd_index for Sv48 and Sv57.

For example, some hypothetical SoC might have RAM starting after 1TB space.

We should ensure that early_pg_dir is cleaned entirely for detecting the next
mode.

Regards,
Anup

>
> Yours,
> Qinglin
> </apatel@ventanamicro.com></mchitale@ventanamicro.com>

\
 
 \ /
  Last update: 2022-04-15 06:57    [W:0.444 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site