Messages in this thread | | | Date | Thu, 14 Apr 2022 11:05:16 +0530 | Subject | Re: [Patch v7 1/4] memory: tegra: Add memory controller channels support | From | Ashish Mhetre <> |
| |
On 4/14/2022 2:47 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > On 4/13/22 12:40, Ashish Mhetre wrote: >> +static int tegra186_mc_map_regs(struct tegra_mc *mc) >> +{ >> + struct platform_device *pdev = to_platform_device(mc->dev); >> + int i; >> + >> + mc->bcast_ch_regs = devm_platform_ioremap_resource_byname(pdev, "broadcast"); >> + if (IS_ERR(mc->bcast_ch_regs)) { >> + if (PTR_ERR(mc->bcast_ch_regs) == -EINVAL) { >> + dev_warn(&pdev->dev, "Broadcast channel is missing, please update your device-tree\n"); > > Set mc->bcast_ch_regs=NULL on error.
It's not really necessary. If mc->bcast_ch_regs == -EINVAL, then interrupts won't occur at all. I have added explanation in patch 2.
| |