Messages in this thread | | | Date | Thu, 14 Apr 2022 08:52:31 -0700 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 09/18] objtool: Add stack validation cmdline option |
| |
On Thu, Apr 14, 2022 at 10:43:25AM +0200, Peter Zijlstra wrote: > On Wed, Apr 13, 2022 at 04:19:44PM -0700, Josh Poimboeuf wrote: > > + if (opts.stackval || opts.orc || opts.uaccess) { > > + ret = validate_functions(file); > > + if (ret < 0) > > + goto out; > > + warnings += ret; > > > > + ret = validate_unwind_hints(file, NULL); > > if (ret < 0) > > goto out; > > warnings += ret; > > + > > + if (!warnings) { > > + ret = validate_reachable_instructions(file); > > + if (ret < 0) > > + goto out; > > + warnings += ret; > > + } > > } > > Doesn't SLS also depend on validate_functions() ?
Doh, I had the intention of splitting that out from validate_branch() like I did for ibt.
-- Josh
| |