lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 433/475] dpaa2-ptp: Fix refcount leak in dpaa2_ptp_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 2b04bd4f03bba021959ca339314f6739710f0954 ]

    This node pointer is returned by of_find_compatible_node() with
    refcount incremented. Calling of_node_put() to aovid the refcount leak.

    Fixes: d346c9e86d86 ("dpaa2-ptp: reuse ptp_qoriq driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220404125336.13427-1-linmq006@gmail.com
    Signed-off-by: Paolo Abeni <pabeni@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
    index 6437fe6b9abf..a6b8f573ab5b 100644
    --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
    +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
    @@ -148,7 +148,7 @@ static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev)
    base = of_iomap(node, 0);
    if (!base) {
    err = -ENOMEM;
    - goto err_close;
    + goto err_put;
    }

    err = fsl_mc_allocate_irqs(mc_dev);
    @@ -191,6 +191,8 @@ static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev)
    fsl_mc_free_irqs(mc_dev);
    err_unmap:
    iounmap(base);
    +err_put:
    + of_node_put(node);
    err_close:
    dprtc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);
    err_free_mcp:
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-04-14 17:21    [W:4.016 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site