lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 463/475] arm64: module: remove (NOLOAD) from linker script
    Date
    From: Fangrui Song <maskray@google.com>

    commit 4013e26670c590944abdab56c4fa797527b74325 upstream.

    On ELF, (NOLOAD) sets the section type to SHT_NOBITS[1]. It is conceptually
    inappropriate for .plt and .text.* sections which are always
    SHT_PROGBITS.

    In GNU ld, if PLT entries are needed, .plt will be SHT_PROGBITS anyway
    and (NOLOAD) will be essentially ignored. In ld.lld, since
    https://reviews.llvm.org/D118840 ("[ELF] Support (TYPE=<value>) to
    customize the output section type"), ld.lld will report a `section type
    mismatch` error. Just remove (NOLOAD) to fix the error.

    [1] https://lld.llvm.org/ELF/linker_script.html As of today, "The
    section should be marked as not loadable" on
    https://sourceware.org/binutils/docs/ld/Output-Section-Type.html is
    outdated for ELF.

    Tested-by: Nathan Chancellor <nathan@kernel.org>
    Reported-by: Nathan Chancellor <nathan@kernel.org>
    Signed-off-by: Fangrui Song <maskray@google.com>
    Acked-by: Ard Biesheuvel <ardb@kernel.org>
    Link: https://lore.kernel.org/r/20220218081209.354383-1-maskray@google.com
    Signed-off-by: Will Deacon <will@kernel.org>
    [nathan: Fix conflicts due to lack of 596b0474d3d9]
    Signed-off-by: Nathan Chancellor <nathan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/arm64/kernel/module.lds | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/arch/arm64/kernel/module.lds
    +++ b/arch/arm64/kernel/module.lds
    @@ -1,5 +1,5 @@
    SECTIONS {
    - .plt 0 (NOLOAD) : { BYTE(0) }
    - .init.plt 0 (NOLOAD) : { BYTE(0) }
    - .text.ftrace_trampoline 0 (NOLOAD) : { BYTE(0) }
    + .plt 0 : { BYTE(0) }
    + .init.plt 0 : { BYTE(0) }
    + .text.ftrace_trampoline 0 : { BYTE(0) }
    }

    \
     
     \ /
      Last update: 2022-04-14 17:21    [W:3.035 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site