lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 459/475] dmaengine: Revert "dmaengine: shdma: Fix runtime PM imbalance on error"
    Date
    From: Vinod Koul <vkoul@kernel.org>

    commit d143f939a95696d38ff800ada14402fa50ebbd6c upstream.

    This reverts commit 455896c53d5b ("dmaengine: shdma: Fix runtime PM
    imbalance on error") as the patch wrongly reduced the count on error and
    did not bail out. So drop the count by reverting the patch .

    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/dma/sh/shdma-base.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/dma/sh/shdma-base.c
    +++ b/drivers/dma/sh/shdma-base.c
    @@ -115,10 +115,8 @@ static dma_cookie_t shdma_tx_submit(stru
    ret = pm_runtime_get(schan->dev);

    spin_unlock_irq(&schan->chan_lock);
    - if (ret < 0) {
    + if (ret < 0)
    dev_err(schan->dev, "%s(): GET = %d\n", __func__, ret);
    - pm_runtime_put(schan->dev);
    - }

    pm_runtime_barrier(schan->dev);


    \
     
     \ /
      Last update: 2022-04-14 17:20    [W:8.433 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site