lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 267/475] selftests: test_vxlan_under_vrf: Fix broken test case
    Date
    From: Ido Schimmel <idosch@nvidia.com>

    [ Upstream commit b50d3b46f84282d795ae3076111acb75ae1031f3 ]

    The purpose of the last test case is to test VXLAN encapsulation and
    decapsulation when the underlay lookup takes place in a non-default VRF.
    This is achieved by enslaving the physical device of the tunnel to a
    VRF.

    The binding of the VXLAN UDP socket to the VRF happens when the VXLAN
    device itself is opened, not when its physical device is opened. This
    was also mentioned in the cited commit ("tests that moving the underlay
    from a VRF to another works when down/up the VXLAN interface"), but the
    test did something else.

    Fix it by reopening the VXLAN device instead of its physical device.

    Before:

    # ./test_vxlan_under_vrf.sh
    Checking HV connectivity [ OK ]
    Check VM connectivity through VXLAN (underlay in the default VRF) [ OK ]
    Check VM connectivity through VXLAN (underlay in a VRF) [FAIL]

    After:

    # ./test_vxlan_under_vrf.sh
    Checking HV connectivity [ OK ]
    Check VM connectivity through VXLAN (underlay in the default VRF) [ OK ]
    Check VM connectivity through VXLAN (underlay in a VRF) [ OK ]

    Fixes: 03f1c26b1c56 ("test/net: Add script for VXLAN underlay in a VRF")
    Signed-off-by: Ido Schimmel <idosch@nvidia.com>
    Reviewed-by: David Ahern <dsahern@kernel.org>
    Link: https://lore.kernel.org/r/20220324200514.1638326-1-idosch@nvidia.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/net/test_vxlan_under_vrf.sh | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/tools/testing/selftests/net/test_vxlan_under_vrf.sh b/tools/testing/selftests/net/test_vxlan_under_vrf.sh
    index 09f9ed92cbe4..a44b9aca7427 100755
    --- a/tools/testing/selftests/net/test_vxlan_under_vrf.sh
    +++ b/tools/testing/selftests/net/test_vxlan_under_vrf.sh
    @@ -118,11 +118,11 @@ echo "[ OK ]"

    # Move the underlay to a non-default VRF
    ip -netns hv-1 link set veth0 vrf vrf-underlay
    -ip -netns hv-1 link set veth0 down
    -ip -netns hv-1 link set veth0 up
    +ip -netns hv-1 link set vxlan0 down
    +ip -netns hv-1 link set vxlan0 up
    ip -netns hv-2 link set veth0 vrf vrf-underlay
    -ip -netns hv-2 link set veth0 down
    -ip -netns hv-2 link set veth0 up
    +ip -netns hv-2 link set vxlan0 down
    +ip -netns hv-2 link set vxlan0 up

    echo -n "Check VM connectivity through VXLAN (underlay in a VRF) "
    ip netns exec vm-1 ping -c 1 -W 1 10.0.0.2 &> /dev/null || (echo "[FAIL]"; false)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 17:11    [W:3.537 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site