lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 236/475] iio: adc: Add check for devm_request_threaded_irq
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit b30537a4cedcacf0ade2f33ebb7610178ed1e7d7 ]

    As the potential failure of the devm_request_threaded_irq(),
    it should be better to check the return value and return
    error if fails.

    Fixes: fa659a40b80b ("iio: adc: twl6030-gpadc: Use devm_* API family")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Link: https://lore.kernel.org/r/20220224062849.3280966-1-jiasheng@iscas.ac.cn
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/adc/twl6030-gpadc.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
    index f24148bd15de..fb77c3ff5a3e 100644
    --- a/drivers/iio/adc/twl6030-gpadc.c
    +++ b/drivers/iio/adc/twl6030-gpadc.c
    @@ -911,6 +911,8 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
    ret = devm_request_threaded_irq(dev, irq, NULL,
    twl6030_gpadc_irq_handler,
    IRQF_ONESHOT, "twl6030_gpadc", indio_dev);
    + if (ret)
    + return ret;

    ret = twl6030_gpadc_enable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK);
    if (ret < 0) {
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 17:10    [W:4.048 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site