lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 380/475] scsi: bfa: Replace snprintf() with sysfs_emit()
    Date
    From: Yang Guang <yang.guang5@zte.com.cn>

    [ Upstream commit 2245ea91fd3a04cafbe2f54911432a8657528c3b ]

    coccinelle report:
    ./drivers/scsi/bfa/bfad_attr.c:908:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:860:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:888:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:853:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:808:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:728:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:822:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:927:9-17:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:900:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:874:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:714:8-16:
    WARNING: use scnprintf or sprintf
    ./drivers/scsi/bfa/bfad_attr.c:839:8-16:
    WARNING: use scnprintf or sprintf

    Use sysfs_emit() instead of scnprintf() or sprintf().

    Link: https://lore.kernel.org/r/def83ff75faec64ba592b867a8499b1367bae303.1643181468.git.yang.guang5@zte.com.cn
    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
    Signed-off-by: David Yang <davidcomponentone@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/bfa/bfad_attr.c | 26 +++++++++++++-------------
    1 file changed, 13 insertions(+), 13 deletions(-)

    diff --git a/drivers/scsi/bfa/bfad_attr.c b/drivers/scsi/bfa/bfad_attr.c
    index fbfce02e5b93..c285f401ff7b 100644
    --- a/drivers/scsi/bfa/bfad_attr.c
    +++ b/drivers/scsi/bfa/bfad_attr.c
    @@ -711,7 +711,7 @@ bfad_im_serial_num_show(struct device *dev, struct device_attribute *attr,
    char serial_num[BFA_ADAPTER_SERIAL_NUM_LEN];

    bfa_get_adapter_serial_num(&bfad->bfa, serial_num);
    - return snprintf(buf, PAGE_SIZE, "%s\n", serial_num);
    + return sysfs_emit(buf, "%s\n", serial_num);
    }

    static ssize_t
    @@ -725,7 +725,7 @@ bfad_im_model_show(struct device *dev, struct device_attribute *attr,
    char model[BFA_ADAPTER_MODEL_NAME_LEN];

    bfa_get_adapter_model(&bfad->bfa, model);
    - return snprintf(buf, PAGE_SIZE, "%s\n", model);
    + return sysfs_emit(buf, "%s\n", model);
    }

    static ssize_t
    @@ -805,7 +805,7 @@ bfad_im_model_desc_show(struct device *dev, struct device_attribute *attr,
    snprintf(model_descr, BFA_ADAPTER_MODEL_DESCR_LEN,
    "Invalid Model");

    - return snprintf(buf, PAGE_SIZE, "%s\n", model_descr);
    + return sysfs_emit(buf, "%s\n", model_descr);
    }

    static ssize_t
    @@ -819,7 +819,7 @@ bfad_im_node_name_show(struct device *dev, struct device_attribute *attr,
    u64 nwwn;

    nwwn = bfa_fcs_lport_get_nwwn(port->fcs_port);
    - return snprintf(buf, PAGE_SIZE, "0x%llx\n", cpu_to_be64(nwwn));
    + return sysfs_emit(buf, "0x%llx\n", cpu_to_be64(nwwn));
    }

    static ssize_t
    @@ -836,7 +836,7 @@ bfad_im_symbolic_name_show(struct device *dev, struct device_attribute *attr,
    bfa_fcs_lport_get_attr(&bfad->bfa_fcs.fabric.bport, &port_attr);
    strlcpy(symname, port_attr.port_cfg.sym_name.symname,
    BFA_SYMNAME_MAXLEN);
    - return snprintf(buf, PAGE_SIZE, "%s\n", symname);
    + return sysfs_emit(buf, "%s\n", symname);
    }

    static ssize_t
    @@ -850,14 +850,14 @@ bfad_im_hw_version_show(struct device *dev, struct device_attribute *attr,
    char hw_ver[BFA_VERSION_LEN];

    bfa_get_pci_chip_rev(&bfad->bfa, hw_ver);
    - return snprintf(buf, PAGE_SIZE, "%s\n", hw_ver);
    + return sysfs_emit(buf, "%s\n", hw_ver);
    }

    static ssize_t
    bfad_im_drv_version_show(struct device *dev, struct device_attribute *attr,
    char *buf)
    {
    - return snprintf(buf, PAGE_SIZE, "%s\n", BFAD_DRIVER_VERSION);
    + return sysfs_emit(buf, "%s\n", BFAD_DRIVER_VERSION);
    }

    static ssize_t
    @@ -871,7 +871,7 @@ bfad_im_optionrom_version_show(struct device *dev,
    char optrom_ver[BFA_VERSION_LEN];

    bfa_get_adapter_optrom_ver(&bfad->bfa, optrom_ver);
    - return snprintf(buf, PAGE_SIZE, "%s\n", optrom_ver);
    + return sysfs_emit(buf, "%s\n", optrom_ver);
    }

    static ssize_t
    @@ -885,7 +885,7 @@ bfad_im_fw_version_show(struct device *dev, struct device_attribute *attr,
    char fw_ver[BFA_VERSION_LEN];

    bfa_get_adapter_fw_ver(&bfad->bfa, fw_ver);
    - return snprintf(buf, PAGE_SIZE, "%s\n", fw_ver);
    + return sysfs_emit(buf, "%s\n", fw_ver);
    }

    static ssize_t
    @@ -897,7 +897,7 @@ bfad_im_num_of_ports_show(struct device *dev, struct device_attribute *attr,
    (struct bfad_im_port_s *) shost->hostdata[0];
    struct bfad_s *bfad = im_port->bfad;

    - return snprintf(buf, PAGE_SIZE, "%d\n",
    + return sysfs_emit(buf, "%d\n",
    bfa_get_nports(&bfad->bfa));
    }

    @@ -905,7 +905,7 @@ static ssize_t
    bfad_im_drv_name_show(struct device *dev, struct device_attribute *attr,
    char *buf)
    {
    - return snprintf(buf, PAGE_SIZE, "%s\n", BFAD_DRIVER_NAME);
    + return sysfs_emit(buf, "%s\n", BFAD_DRIVER_NAME);
    }

    static ssize_t
    @@ -924,14 +924,14 @@ bfad_im_num_of_discovered_ports_show(struct device *dev,
    rports = kcalloc(nrports, sizeof(struct bfa_rport_qualifier_s),
    GFP_ATOMIC);
    if (rports == NULL)
    - return snprintf(buf, PAGE_SIZE, "Failed\n");
    + return sysfs_emit(buf, "Failed\n");

    spin_lock_irqsave(&bfad->bfad_lock, flags);
    bfa_fcs_lport_get_rport_quals(port->fcs_port, rports, &nrports);
    spin_unlock_irqrestore(&bfad->bfad_lock, flags);
    kfree(rports);

    - return snprintf(buf, PAGE_SIZE, "%d\n", nrports);
    + return sysfs_emit(buf, "%d\n", nrports);
    }

    static DEVICE_ATTR(serial_number, S_IRUGO,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-04-14 17:08    [W:3.142 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site