lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 250/475] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit dab4df9ca919f59e5b9dd84385eaf34d4f20dbb0 ]

    The device_node pointer is returned by of_parse_phandle() with refcount
    incremented. We should use of_node_put() on it when done.

    Fixes: a6df410d420a ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Link: https://lore.kernel.org/r/20220308071155.21114-1-linmq006@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
    index 53f52b9a0acd..c2df70712ca2 100644
    --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
    +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
    @@ -1038,6 +1038,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
    node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
    if (node) {
    pctl->regmap1 = syscon_node_to_regmap(node);
    + of_node_put(node);
    if (IS_ERR(pctl->regmap1))
    return PTR_ERR(pctl->regmap1);
    } else if (regmap) {
    @@ -1051,6 +1052,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
    node = of_parse_phandle(np, "mediatek,pctl-regmap", 1);
    if (node) {
    pctl->regmap2 = syscon_node_to_regmap(node);
    + of_node_put(node);
    if (IS_ERR(pctl->regmap2))
    return PTR_ERR(pctl->regmap2);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:45    [W:4.087 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site