lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 251/475] pinctrl: mediatek: paris: Fix "argument" argument type for mtk_pinconf_get()
    Date
    From: Chen-Yu Tsai <wenst@chromium.org>

    [ Upstream commit 19bce7ce0a593c7024030a0cda9e23facea3c93d ]

    For mtk_pinconf_get(), the "argument" argument is typically returned by
    pinconf_to_config_argument(), which holds the value for a given pinconf
    parameter. It certainly should not have the type of "enum pin_config_param",
    which describes the type of the pinconf parameter itself.

    Change the type to u32, which matches the return type of
    pinconf_to_config_argument().

    Fixes: 805250982bb5 ("pinctrl: mediatek: add pinctrl-paris that implements the vendor dt-bindings")
    Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Link: https://lore.kernel.org/r/20220308100956.2750295-4-wenst@chromium.org
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/mediatek/pinctrl-paris.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
    index 923264d0e9ef..e8bfaaccca68 100644
    --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
    +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
    @@ -198,8 +198,7 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
    }

    static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
    - enum pin_config_param param,
    - enum pin_config_param arg)
    + enum pin_config_param param, u32 arg)
    {
    struct mtk_pinctrl *hw = pinctrl_dev_get_drvdata(pctldev);
    const struct mtk_pin_desc *desc;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:45    [W:4.028 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site