lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 180/475] iwlwifi: Fix -EIO error code that is never returned
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit c305c94bdc18e45b5ad1db54da4269f8cbfdff6b ]

    Currently the error -EIO is being assinged to variable ret when
    the READY_BIT is not set but the function iwlagn_mac_start returns
    0 rather than ret. Fix this by returning ret instead of 0.

    Addresses-Coverity: ("Unused value")
    Fixes: 7335613ae27a ("iwlwifi: move all mac80211 related functions to one place")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Link: https://lore.kernel.org/r/20210907104658.14706-1-colin.king@canonical.com
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c
    index 6512d25e3563..f3bb1f91b587 100644
    --- a/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c
    +++ b/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c
    @@ -303,7 +303,7 @@ static int iwlagn_mac_start(struct ieee80211_hw *hw)

    priv->is_open = 1;
    IWL_DEBUG_MAC80211(priv, "leave\n");
    - return 0;
    + return ret;
    }

    static void iwlagn_mac_stop(struct ieee80211_hw *hw)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:42    [W:2.060 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site