lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 217/475] USB: storage: ums-realtek: fix error code in rts51x_read_mem()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit b07cabb8361dc692522538205552b1b9dab134be ]

    The rts51x_read_mem() function should return negative error codes.
    Currently if the kmalloc() fails it returns USB_STOR_TRANSPORT_ERROR (3)
    which is treated as success by the callers.

    Fixes: 065e60964e29 ("ums_realtek: do not use stack memory for DMA")
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/20220304073504.GA26464@kili
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/storage/realtek_cr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
    index 3789698d9d3c..0c423916d7bf 100644
    --- a/drivers/usb/storage/realtek_cr.c
    +++ b/drivers/usb/storage/realtek_cr.c
    @@ -365,7 +365,7 @@ static int rts51x_read_mem(struct us_data *us, u16 addr, u8 *data, u16 len)

    buf = kmalloc(len, GFP_NOIO);
    if (buf == NULL)
    - return USB_STOR_TRANSPORT_ERROR;
    + return -ENOMEM;

    usb_stor_dbg(us, "addr = 0x%x, len = %d\n", addr, len);

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:42    [W:2.303 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site