lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 144/475] ASoC: atmel: Add missing of_node_put() in at91sam9g20ek_audio_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit f590797fa3c1bccdd19e55441592a23b46aef449 ]

    This node pointer is returned by of_parse_phandle() with refcount
    incremented in this function.
    Calling of_node_put() to avoid the refcount leak.

    Fixes: 531f67e41dcd ("ASoC: at91sam9g20ek-wm8731: convert to dt support")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
    Link: https://lore.kernel.org/r/20220307124539.1743-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/atmel/sam9g20_wm8731.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
    index b1bef2bf142d..05277a88e20d 100644
    --- a/sound/soc/atmel/sam9g20_wm8731.c
    +++ b/sound/soc/atmel/sam9g20_wm8731.c
    @@ -214,6 +214,7 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev)
    cpu_np = of_parse_phandle(np, "atmel,ssc-controller", 0);
    if (!cpu_np) {
    dev_err(&pdev->dev, "dai and pcm info missing\n");
    + of_node_put(codec_np);
    return -EINVAL;
    }
    at91sam9g20ek_dai.cpus->of_node = cpu_np;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:41    [W:4.021 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site