lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 036/475] NFSD: prevent underflow in nfssvc_decode_writeargs()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 184416d4b98509fb4c3d8fc3d6dc1437896cc159 upstream.

    Smatch complains:

    fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs()
    warn: no lower bound on 'args->len'

    Change the type to unsigned to prevent this issue.

    Cc: stable@vger.kernel.org
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/nfsd/nfsproc.c | 2 +-
    fs/nfsd/xdr.h | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/fs/nfsd/nfsproc.c
    +++ b/fs/nfsd/nfsproc.c
    @@ -230,7 +230,7 @@ nfsd_proc_write(struct svc_rqst *rqstp)
    unsigned long cnt = argp->len;
    unsigned int nvecs;

    - dprintk("nfsd: WRITE %s %d bytes at %d\n",
    + dprintk("nfsd: WRITE %s %u bytes at %d\n",
    SVCFH_fmt(&argp->fh),
    argp->len, argp->offset);

    --- a/fs/nfsd/xdr.h
    +++ b/fs/nfsd/xdr.h
    @@ -33,7 +33,7 @@ struct nfsd_readargs {
    struct nfsd_writeargs {
    svc_fh fh;
    __u32 offset;
    - int len;
    + __u32 len;
    struct kvec first;
    };


    \
     
     \ /
      Last update: 2022-04-14 16:41    [W:3.854 / U:1.908 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site