lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 150/475] ASoC: mxs: Fix error handling in mxs_sgtl5000_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 6ae0a4d8fec551ec581d620f0eb1fe31f755551c ]

    This function only calls of_node_put() in the regular path.
    And it will cause refcount leak in error paths.
    For example, when codec_np is NULL, saif_np[0] and saif_np[1]
    are not NULL, it will cause leaks.

    of_node_put() will check if the node pointer is NULL, so we can
    call it directly to release the refcount of regular pointers.

    Fixes: e968194b45c4 ("ASoC: mxs: add device tree support for mxs-sgtl5000")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220308020146.26496-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/mxs/mxs-sgtl5000.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c
    index 9841e1da9782..8282fe6d00dd 100644
    --- a/sound/soc/mxs/mxs-sgtl5000.c
    +++ b/sound/soc/mxs/mxs-sgtl5000.c
    @@ -118,6 +118,9 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev)
    codec_np = of_parse_phandle(np, "audio-codec", 0);
    if (!saif_np[0] || !saif_np[1] || !codec_np) {
    dev_err(&pdev->dev, "phandle missing or invalid\n");
    + of_node_put(codec_np);
    + of_node_put(saif_np[0]);
    + of_node_put(saif_np[1]);
    return -EINVAL;
    }

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:41    [W:4.041 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site