lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 167/475] power: reset: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit ba18dad0fb880cd29aa97b6b75560ef14d1061ba ]

    platform_get_irq() returns negative error number instead 0 on failure.
    And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
    return irq;

    Fix the check of return value to catch errors correctly.

    Fixes: f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/power/reset/gemini-poweroff.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/power/reset/gemini-poweroff.c b/drivers/power/reset/gemini-poweroff.c
    index 90e35c07240a..b7f7a8225f22 100644
    --- a/drivers/power/reset/gemini-poweroff.c
    +++ b/drivers/power/reset/gemini-poweroff.c
    @@ -107,8 +107,8 @@ static int gemini_poweroff_probe(struct platform_device *pdev)
    return PTR_ERR(gpw->base);

    irq = platform_get_irq(pdev, 0);
    - if (!irq)
    - return -EINVAL;
    + if (irq < 0)
    + return irq;

    gpw->dev = dev;

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:35    [W:4.150 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site